From f9e533097cb8a5c0a4ae75c544bccaf7cacf3db7 Mon Sep 17 00:00:00 2001 From: Moritz Eysholdt Date: Thu, 1 Dec 2011 13:09:25 +0100 Subject: [PATCH] Revert "[Xtext] fixed 363914 - Check that you cannot append a null segment to a" This reverts commit b74a06f705a9a0750289e2152d49941f4727e756. --- .../src/org/eclipse/xtext/naming/QualifiedName.java | 3 --- .../src/org/eclipse/xtext/naming/QualifiedNameTest.java | 7 ------- 2 files changed, 10 deletions(-) diff --git a/plugins/org.eclipse.xtext/src/org/eclipse/xtext/naming/QualifiedName.java b/plugins/org.eclipse.xtext/src/org/eclipse/xtext/naming/QualifiedName.java index 55075317f..b207abb47 100644 --- a/plugins/org.eclipse.xtext/src/org/eclipse/xtext/naming/QualifiedName.java +++ b/plugins/org.eclipse.xtext/src/org/eclipse/xtext/naming/QualifiedName.java @@ -95,9 +95,6 @@ public class QualifiedName implements Comparable { } public QualifiedName append(String segment) { - if (segment == null) { - throw new IllegalArgumentException("Segment cannot be null"); - } String[] newSegments = new String[getSegmentCount() + 1]; System.arraycopy(segments, 0, newSegments, 0, segments.length); newSegments[segments.length] = segment; diff --git a/tests/org.eclipse.xtext.tests/src/org/eclipse/xtext/naming/QualifiedNameTest.java b/tests/org.eclipse.xtext.tests/src/org/eclipse/xtext/naming/QualifiedNameTest.java index 1ddf2f7a7..49772b0bd 100644 --- a/tests/org.eclipse.xtext.tests/src/org/eclipse/xtext/naming/QualifiedNameTest.java +++ b/tests/org.eclipse.xtext.tests/src/org/eclipse/xtext/naming/QualifiedNameTest.java @@ -25,13 +25,6 @@ public class QualifiedNameTest extends TestCase { fail("Exception expected"); } catch(IllegalArgumentException e) {} } - - public void testAppendNull() { - try { - QualifiedName.create().append((String) null); - fail("Exception expected"); - } catch (IllegalArgumentException e) {} - } public void testSegments() { QualifiedName qn = QualifiedName.create("foo", "bar", "baz");