From b78d337a9c4caa4fee333f5addaf75b613d18ad6 Mon Sep 17 00:00:00 2001 From: Christian Dietrich Date: Tue, 26 Nov 2019 10:25:26 +0100 Subject: [PATCH] review feedback Signed-off-by: Christian Dietrich --- .../generator/parser/antlr/ex/ExternalAntlrLexerFragment.java | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/org.eclipse.xtext.xtext.generator/src/org/eclipse/xtext/xtext/generator/parser/antlr/ex/ExternalAntlrLexerFragment.java b/org.eclipse.xtext.xtext.generator/src/org/eclipse/xtext/xtext/generator/parser/antlr/ex/ExternalAntlrLexerFragment.java index 5a328de45..3567501c7 100644 --- a/org.eclipse.xtext.xtext.generator/src/org/eclipse/xtext/xtext/generator/parser/antlr/ex/ExternalAntlrLexerFragment.java +++ b/org.eclipse.xtext.xtext.generator/src/org/eclipse/xtext/xtext/generator/parser/antlr/ex/ExternalAntlrLexerFragment.java @@ -18,6 +18,8 @@ import org.eclipse.xtext.xtext.generator.parser.antlr.AbstractAntlrGeneratorFrag import com.google.common.annotations.Beta; /** + * Use this fragment if you want to use an external lexer , e.g: in case the generated lexer has to be customized. + * * @since 2.20 * @author dietrich - Initial contribution and API */ @@ -34,7 +36,6 @@ public class ExternalAntlrLexerFragment extends AbstractAntlrGeneratorFragment2 @Override protected void doGenerate() { - // i am not sure when to generate what if (runtime) { StringConcatenationClient binding = new StringConcatenationClient() { @Override