From 8fac71dda933389e90d296588e8c1c51973ffa9f Mon Sep 17 00:00:00 2001 From: overflowerror Date: Sat, 25 Dec 2021 16:41:19 +0100 Subject: [PATCH] added comment to failing test case testRecursiveRuleCallingAlternative_expectCorrectGuard guard for nested alternatives might not be optimal if the positions that discriminate in the first alternatives is different from the positions needed on the next one --- .../xtext/xtext/generator/hoisting/HoistingProcessorTest.java | 2 ++ 1 file changed, 2 insertions(+) diff --git a/org.eclipse.xtext.tests/src/org/eclipse/xtext/xtext/generator/hoisting/HoistingProcessorTest.java b/org.eclipse.xtext.tests/src/org/eclipse/xtext/xtext/generator/hoisting/HoistingProcessorTest.java index 43620d876..1aa724a60 100644 --- a/org.eclipse.xtext.tests/src/org/eclipse/xtext/xtext/generator/hoisting/HoistingProcessorTest.java +++ b/org.eclipse.xtext.tests/src/org/eclipse/xtext/xtext/generator/hoisting/HoistingProcessorTest.java @@ -793,6 +793,8 @@ public class HoistingProcessorTest extends AbstractXtextTests { assertEquals("((" + getSyntaxForKeywordToken("a", 2) + " || " + getSyntaxForKeywordToken("b", 1) + " || ((p0) && (p2))) && (" + getSyntaxForKeywordToken("b", 2) + " || " + getSyntaxForKeywordToken("b", 1) + " || ((p0) && (p3))) && (" + getSyntaxForKeywordToken("a", 1) + " || (p1)))", guard.render()); } + // currently not able to find optimal solution + // for that we would not to collapse alternatives before constructing guards @Test public void testRecursiveRuleCallingAlternative_expectCorrectGuard() throws Exception { // @formatter:off