sigmasternchen/xtext-core
1
0
Fork 0
mirror of https://github.com/sigmasternchen/xtext-core synced 2025-03-16 08:48:55 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Bug 484465: Improved performance of GrammarConstraintProvider.Constraint#collectBounds()

Browse source 
Signed-off-by: Miro Spönemann <miro.spoenemann@typefox.io>
This commit is contained in:
Miro Spönemann 2016-02-29 17:44:30 +01:00
parent 92cdc8ca9a
commit 613390a021
1 changed files with 12 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
plugins/org.eclipse.xtext/src/org/eclipse/xtext/serializer/analysis/GrammarConstraintProvider.java
View file

@ -85,10 +85,14 @@ public class GrammarConstraintProvider implements IGrammarConstraintProvider {
protected void collectBounds(ISemState state, int[] current, Set<ISemState> visited, int[] min, int[] max) {
int featureID = state.getFeatureID();
int previousValue = -1;
boolean newVisit = false;
if (featureID >= 0) {
if (current[featureID] == IGrammarConstraintProvider.MAX)
return;
if (visited.add(state))
previousValue = current[featureID];
newVisit = visited.add(state);
if (newVisit)
current[featureID]++;
else
current[featureID] = IGrammarConstraintProvider.MAX;
@ -99,8 +103,13 @@ public class GrammarConstraintProvider implements IGrammarConstraintProvider {
}
return;
}
for (ISemState follower : state.getFollowers())
collectBounds(follower, current.clone(), Sets.newHashSet(visited), min, max);
for (ISemState follower : state.getFollowers()) {
collectBounds(follower, current, visited, min, max);
}
if (previousValue >= 0)
current[featureID] = previousValue;
if (newVisit)
visited.remove(state);
}
@Override