Commit graph

256 commits

Author SHA1 Message Date
Sergey Panteleev
184f3f7bd4
Remove PHP 5, 7 references (#565) 2021-05-12 14:49:16 +03:00
Sergey Panteleev
f9c4a68ef4
Removed references to PHP 5, PHP 7.0 (#548) 2021-04-26 11:46:55 +03:00
Sergey Panteleev
aab33d6443
Removed references to PHP 5, PHP 7.0 (#544) 2021-04-23 11:35:26 +03:00
Ayesh Karunaratne
61f5c7a1f5 Fix CURLOPT_MAXREDIRS/FOLLOWLOCATION descriptions
Currently, the description for `CURLOPT_FOLLOWLOCATION` and `CURLOPT_MAXREDIRS` indicates that unless a `CURLOPT_MAXREDIRS` value is set, Curl will do an infinite loop.

However, this is not the case, because PHP internally sets a default value of 20. Please see:
 - [`ext/curl/interface.c`](d0e3fb495f/ext/curl/interface.c (L1806))
 - [PHP Curl Security Hardening: Infinite loops](https://php.watch/articles/php-curl-security-hardening#infinite-redirects)
 - [Libcurl: CURLOPT_MAXREDIRS.html](https://curl.se/libcurl/c/CURLOPT_MAXREDIRS.html)

The default libcurl behavior is indeed to not limit the number of redirects, which enables infinite loops, but I think we probably should keep the PHP's sane default of 20, and update the documentation instead.

Closes GH-371.
2021-01-22 14:02:21 +01:00
Christoph Michael Becker
e41806c30b Revert revision(s) 351724 from phpdoc/en/trunk:
Document false and null return types

Cf. <https://news-web.php.net/php.doc.cvs/17645>.


git-svn-id: https://svn.php.net/repository/phpdoc/en/trunk@351730 c90b9560-bf6c-de11-be94-00142212c4b1
2020-11-28 18:05:44 +00:00
Jakub Vrana
c80da7c04a Document false and null return types
git-svn-id: https://svn.php.net/repository/phpdoc/en/trunk@351724 c90b9560-bf6c-de11-be94-00142212c4b1
2020-11-28 12:54:59 +00:00
Christoph Michael Becker
24a693e9a4 Fix parameter name
Cf. <https://github.com/php/php-src/pull/6435>.


git-svn-id: https://svn.php.net/repository/phpdoc/en/trunk@351624 c90b9560-bf6c-de11-be94-00142212c4b1
2020-11-25 01:31:30 +00:00
Christoph Michael Becker
b7f8c11e56 Generate curl methodsynopses based on stubs
Amended by cmb.

Closes GH-231.


git-svn-id: https://svn.php.net/repository/phpdoc/en/trunk@351621 c90b9560-bf6c-de11-be94-00142212c4b1
2020-11-25 00:58:58 +00:00
Christoph Michael Becker
b39b2fcb92 Remove obsolete PHP 5 specific info regarding cURL file uploads
git-svn-id: https://svn.php.net/repository/phpdoc/en/trunk@351291 c90b9560-bf6c-de11-be94-00142212c4b1
2020-11-07 14:33:22 +00:00
Christoph Michael Becker
b95d28e6ec Fix return types
Functions which return false on failure should state that in their
signature as well.


git-svn-id: https://svn.php.net/repository/phpdoc/en/trunk@351135 c90b9560-bf6c-de11-be94-00142212c4b1
2020-11-02 15:52:35 +00:00
Christoph Michael Becker
86e6094e86 Use canonical type names
git-svn-id: https://svn.php.net/repository/phpdoc/en/trunk@351133 c90b9560-bf6c-de11-be94-00142212c4b1
2020-11-02 15:39:04 +00:00
Christoph Michael Becker
9af43469f4 Remove more changelog entries, mostly from PHP 5.2 era
Patch contributed by Sobak <msobaczewski@gmail.com>.


git-svn-id: https://svn.php.net/repository/phpdoc/en/trunk@350654 c90b9560-bf6c-de11-be94-00142212c4b1
2020-09-26 13:52:31 +00:00
Christoph Michael Becker
be5b0f33a1 Remove more changelog entries, mostly from PHP 5.1 era
Patch contributed by Sobak <msobaczewski@gmail.com>.


git-svn-id: https://svn.php.net/repository/phpdoc/en/trunk@350653 c90b9560-bf6c-de11-be94-00142212c4b1
2020-09-26 13:45:57 +00:00
Christoph Michael Becker
53bdffa6b9 Removed some of the PHP5 changelogs
Patch contributed by Sobak <msobaczewski@gmail.com>.


git-svn-id: https://svn.php.net/repository/phpdoc/en/trunk@350645 c90b9560-bf6c-de11-be94-00142212c4b1
2020-09-26 12:32:19 +00:00
Christoph Michael Becker
e020f80412 fix ugly bug in sample code
imagine if 2 handles finish in the same multi_exec(), before exec() $active is 2 and after the call $active is 0, then we read the first message, and the the message from the 2nd handle will be lost/ignored!

this has caused real bugs in the wild, see https://stackoverflow.com/questions/61920359/count-how-many-curl-multi-requests-have-been-made/61923372

Patch provided by divinity76.


git-svn-id: https://svn.php.net/repository/phpdoc/en/trunk@349952 c90b9560-bf6c-de11-be94-00142212c4b1
2020-05-21 09:35:34 +00:00
Christoph Michael Becker
aebf045bfb Fix miscellaneous typos
Detected by codespell

Patch provided by tandre@php.net.


git-svn-id: https://svn.php.net/repository/phpdoc/en/trunk@349708 c90b9560-bf6c-de11-be94-00142212c4b1
2020-04-27 06:43:55 +00:00
Christoph Michael Becker
67e6fdb205 Document missing CURLOPT_HTTP_VERSION values
git-svn-id: https://svn.php.net/repository/phpdoc/en/trunk@349505 c90b9560-bf6c-de11-be94-00142212c4b1
2020-03-20 15:10:04 +00:00
Christoph Michael Becker
d3c48b9ae3 Properly mark up constants as such
While these constants are supposed to be passed as argument, they are not
parameters per se.  Furthermore, parameters are linked to their declaration
in the PHP rendered version at least, and since there is no declaration,
the links are most useless.


git-svn-id: https://svn.php.net/repository/phpdoc/en/trunk@349504 c90b9560-bf6c-de11-be94-00142212c4b1
2020-03-20 15:07:42 +00:00
Christoph Michael Becker
12bae73457 Fix #72611: CURLOPT_TCP_KEEPALIVE missing
git-svn-id: https://svn.php.net/repository/phpdoc/en/trunk@349396 c90b9560-bf6c-de11-be94-00142212c4b1
2020-03-12 17:08:49 +00:00
Christoph Michael Becker
39ed941a15 Fix #77792: CURLOPT_SSLCERTTYPE support P12(pfx) certificate
git-svn-id: https://svn.php.net/repository/phpdoc/en/trunk@349395 c90b9560-bf6c-de11-be94-00142212c4b1
2020-03-12 16:12:54 +00:00
Christoph Michael Becker
a8356baaf4 Fix #78367: missing CURL_SSLVERSION_MAX_xxx
git-svn-id: https://svn.php.net/repository/phpdoc/en/trunk@349394 c90b9560-bf6c-de11-be94-00142212c4b1
2020-03-12 16:07:42 +00:00
Christoph Michael Becker
5d93330c9b Fix #78435: Missing CURLOPT_COOKIELIST in doc
git-svn-id: https://svn.php.net/repository/phpdoc/en/trunk@349393 c90b9560-bf6c-de11-be94-00142212c4b1
2020-03-12 15:52:53 +00:00
Christoph Michael Becker
46b3f856ba Fix #79105: curl_share_setopt incorrect argument type
git-svn-id: https://svn.php.net/repository/phpdoc/en/trunk@349391 c90b9560-bf6c-de11-be94-00142212c4b1
2020-03-12 15:38:49 +00:00
Christoph Michael Becker
9e8923833c Fix the table of integer values on setopt page
Patch provided by Ekin.


git-svn-id: https://svn.php.net/repository/phpdoc/en/trunk@349197 c90b9560-bf6c-de11-be94-00142212c4b1
2020-02-10 14:30:32 +00:00
Christoph Michael Becker
e6dfcca365 Fix changelog order
Should always be from in reverse chronological order.

git-svn-id: https://svn.php.net/repository/phpdoc/en/trunk@349186 c90b9560-bf6c-de11-be94-00142212c4b1
2020-02-09 10:48:36 +00:00
Nikita Popov
e5731b4787 Document missing curl constants added in 7.3.x
Patch by ekinhbayar.

Closes php/doc-en#27.

git-svn-id: https://svn.php.net/repository/phpdoc/en/trunk@349125 c90b9560-bf6c-de11-be94-00142212c4b1
2020-02-05 08:54:11 +00:00
Nikita Popov
ec67793395 Fixes #79186
Patch by ekinhbayar.

Closes php/doc-en#28.

git-svn-id: https://svn.php.net/repository/phpdoc/en/trunk@349069 c90b9560-bf6c-de11-be94-00142212c4b1
2020-01-30 14:45:43 +00:00
Christoph Michael Becker
162080c9d0 Document CURLOPT_HTTP09_ALLOWED
Cf. <https://github.com/php/php-src/pull/5114>.


git-svn-id: https://svn.php.net/repository/phpdoc/en/trunk@349025 c90b9560-bf6c-de11-be94-00142212c4b1
2020-01-26 13:42:43 +00:00
Christoph Michael Becker
25cfe14df1 Fix #79097: CURLOPT_HTTP_CONTENT_DECODING is not documented
git-svn-id: https://svn.php.net/repository/phpdoc/en/trunk@348881 c90b9560-bf6c-de11-be94-00142212c4b1
2020-01-12 10:11:39 +00:00
Christoph Michael Becker
6c9c135b41 Fix URL
Patch provided by anonymous user.

git-svn-id: https://svn.php.net/repository/phpdoc/en/trunk@347496 c90b9560-bf6c-de11-be94-00142212c4b1
2019-05-27 13:57:18 +00:00
Christoph Michael Becker
3672e4f13d Update and clarify CURLMOPT_PIPELINING docs
git-svn-id: https://svn.php.net/repository/phpdoc/en/trunk@347375 c90b9560-bf6c-de11-be94-00142212c4b1
2019-05-03 13:55:31 +00:00
George Peter Banyard
0b3846c465 Nitpick, "etc." and "..." are equivalent using "etc..." is as saying "Et cetera Et cetera"
git-svn-id: https://svn.php.net/repository/phpdoc/en/trunk@347154 c90b9560-bf6c-de11-be94-00142212c4b1
2019-04-05 20:07:42 +00:00
Sara Golemon
38842fa7dc Clarify that non-thread safe setting CURLOPT_DNS_USE_GLOBAL_CACHE is only enabled when it makes sense.
git-svn-id: https://svn.php.net/repository/phpdoc/en/trunk@347135 c90b9560-bf6c-de11-be94-00142212c4b1
2019-04-04 14:04:02 +00:00
Peter Cowburn
e16c1b4587 improve curl_multi_exec() loops (doc #77682)
curl_multi_exec() hasn't returned CURLM_CALL_MULTI_PERFORM for a loooong
time (it stopped doing so as of libcurl 7.20.0, which was released on
Feb 9 2010).

Thanks to Daniel Stenberg for the details.

git-svn-id: https://svn.php.net/repository/phpdoc/en/trunk@346933 c90b9560-bf6c-de11-be94-00142212c4b1
2019-02-28 22:00:16 +00:00
Christoph Michael Becker
91bd082167 Fix #76328: Documentation of CURLINFO_HTTP_CODE as legacy
git-svn-id: https://svn.php.net/repository/phpdoc/en/trunk@345002 c90b9560-bf6c-de11-be94-00142212c4b1
2018-05-11 16:11:29 +00:00
Christoph Michael Becker
96714651c2 Fix typo
Patch provided by anonymous user.

git-svn-id: https://svn.php.net/repository/phpdoc/en/trunk@344978 c90b9560-bf6c-de11-be94-00142212c4b1
2018-05-08 11:38:46 +00:00
Christoph Michael Becker
eceb032b47 Fix grammar
Patch provided by anonymous user.

git-svn-id: https://svn.php.net/repository/phpdoc/en/trunk@344861 c90b9560-bf6c-de11-be94-00142212c4b1
2018-04-27 13:51:22 +00:00
Christoph Michael Becker
7fb49b6b4f Clarify meaning of success/failure
This also integrates user note 87015.

git-svn-id: https://svn.php.net/repository/phpdoc/en/trunk@344669 c90b9560-bf6c-de11-be94-00142212c4b1
2018-04-14 16:04:54 +00:00
Jakub Vrana
dd07341fae Remove trailing fullstop in <refpurpose>
git-svn-id: https://svn.php.net/repository/phpdoc/en/trunk@343888 c90b9560-bf6c-de11-be94-00142212c4b1
2018-01-25 15:34:22 +00:00
Christoph Michael Becker
aacd13217f Log: Partially fix #75094: Functions not documented
We document the curl_*() functions which have been
introduced in PHP 7.1.0.

git-svn-id: https://svn.php.net/repository/phpdoc/en/trunk@342910 c90b9560-bf6c-de11-be94-00142212c4b1
2017-08-22 15:07:32 +00:00
Pieter Hordijk
3162d2eadc Added in the description for CURLOPT_RESOLVE based on Curl's manpage, searching the PHP source code, and the bug report that brought it into the source code for 5.5
-- 
Provided by anonymous 84525 (toby.bettridge@stubside.com)

git-svn-id: https://svn.php.net/repository/phpdoc/en/trunk@342670 c90b9560-bf6c-de11-be94-00142212c4b1
2017-07-16 18:38:13 +00:00
Christoph Michael Becker
cdf488a697 CURLOPT_SAFE_UPLOAD has been removed as of PHP 7.0.0
git-svn-id: https://svn.php.net/repository/phpdoc/en/trunk@341917 c90b9560-bf6c-de11-be94-00142212c4b1
2017-02-17 18:03:48 +00:00
Christoph Michael Becker
97ca95ebfa Update docs for PHP 7.0.0
Patch provided by anon user.

git-svn-id: https://svn.php.net/repository/phpdoc/en/trunk@341914 c90b9560-bf6c-de11-be94-00142212c4b1
2017-02-17 17:50:56 +00:00
Christoph Michael Becker
82d8f6e36b Document cURL server push support (as of PHP 7.1.0)
git-svn-id: https://svn.php.net/repository/phpdoc/en/trunk@341647 c90b9560-bf6c-de11-be94-00142212c4b1
2017-01-12 17:32:00 +00:00
Christoph Michael Becker
bb280fc0f2 Fix #69117: CURLOPT_SSL_VERIFYHOST: lack of documentation for value 0
git-svn-id: https://svn.php.net/repository/phpdoc/en/trunk@341538 c90b9560-bf6c-de11-be94-00142212c4b1
2016-12-30 12:10:29 +00:00
Christoph Michael Becker
2c649053d0 Improve CURLOPT_PINNEDPUBLICKEY documentation
git-svn-id: https://svn.php.net/repository/phpdoc/en/trunk@340038 c90b9560-bf6c-de11-be94-00142212c4b1
2016-09-15 10:36:28 +00:00
Christoph Michael Becker
265c283cb5 Fix #72890: The description of CURLMOPT_MAXCONNECTS is wrong
git-svn-id: https://svn.php.net/repository/phpdoc/en/trunk@339909 c90b9560-bf6c-de11-be94-00142212c4b1
2016-08-19 08:47:29 +00:00
Christoph Michael Becker
5435723c4c CURLINFO_FILETIME requires CURLOPT_FILETIME
git-svn-id: https://svn.php.net/repository/phpdoc/en/trunk@339608 c90b9560-bf6c-de11-be94-00142212c4b1
2016-07-10 10:39:17 +00:00
Christoph Michael Becker
f5700836b5 Document cURL constant added in PHP 7.0.7 plus a few added in PHP 5.5.0
Fixes also bug #72522 (No option CURLOPT_UNIX_SOCKET_PATH).

git-svn-id: https://svn.php.net/repository/phpdoc/en/trunk@339547 c90b9560-bf6c-de11-be94-00142212c4b1
2016-07-03 16:54:52 +00:00
Christoph Michael Becker
d6f9689aae Fix #64798: curl_getinfo does not return info array if $opt = 0
Actually, $opt has no default value!

git-svn-id: https://svn.php.net/repository/phpdoc/en/trunk@339443 c90b9560-bf6c-de11-be94-00142212c4b1
2016-06-21 20:45:47 +00:00