From d26548d3357ea3f9488463de6192db814bd05826 Mon Sep 17 00:00:00 2001
From: George Peter Banyard <girgias@php.net>
Date: Sun, 13 Jun 2021 19:33:50 +0100
Subject: [PATCH] Fix most section issues in OCI8

Part of #658
---
 reference/oci8/OCI-Collection/free.xml        |  5 ++
 reference/oci8/OCI-Collection/max.xml         |  5 ++
 reference/oci8/OCI-Collection/size.xml        |  5 ++
 reference/oci8/OCI-Lob/close.xml              |  5 ++
 reference/oci8/OCI-Lob/eof.xml                | 23 +++++---
 reference/oci8/OCI-Lob/free.xml               |  5 ++
 reference/oci8/OCI-Lob/getBuffering.xml       |  5 ++
 reference/oci8/OCI-Lob/load.xml               |  5 ++
 reference/oci8/OCI-Lob/rewind.xml             |  5 ++
 reference/oci8/OCI-Lob/size.xml               |  5 ++
 reference/oci8/OCI-Lob/tell.xml               |  5 ++
 reference/oci8/functions/oci-bind-by-name.xml |  9 +--
 reference/oci8/functions/oci-set-edition.xml  | 58 +++++++++----------
 .../oci8/functions/oci-set-module-name.xml    | 14 ++---
 14 files changed, 101 insertions(+), 53 deletions(-)

diff --git a/reference/oci8/OCI-Collection/free.xml b/reference/oci8/OCI-Collection/free.xml
index ecd94e146b..00aa46bea9 100644
--- a/reference/oci8/OCI-Collection/free.xml
+++ b/reference/oci8/OCI-Collection/free.xml
@@ -17,6 +17,11 @@
   </para>
  </refsect1>
 
+ <refsect1 role="parameters">
+  &reftitle.parameters;
+  &no.function.parameters;
+ </refsect1>
+
  <refsect1 role="returnvalues">
   &reftitle.returnvalues;
   <para>
diff --git a/reference/oci8/OCI-Collection/max.xml b/reference/oci8/OCI-Collection/max.xml
index e7498b7de1..72b42560bd 100644
--- a/reference/oci8/OCI-Collection/max.xml
+++ b/reference/oci8/OCI-Collection/max.xml
@@ -17,6 +17,11 @@
   </para>
  </refsect1>
 
+ <refsect1 role="parameters">
+  &reftitle.parameters;
+  &no.function.parameters;
+ </refsect1>
+
  <refsect1 role="returnvalues">
   &reftitle.returnvalues;
   <para>
diff --git a/reference/oci8/OCI-Collection/size.xml b/reference/oci8/OCI-Collection/size.xml
index 571a89fe99..3ec5918889 100644
--- a/reference/oci8/OCI-Collection/size.xml
+++ b/reference/oci8/OCI-Collection/size.xml
@@ -17,6 +17,11 @@
   </para>
  </refsect1>
 
+ <refsect1 role="parameters">
+  &reftitle.parameters;
+  &no.function.parameters;
+ </refsect1>
+
  <refsect1 role="returnvalues">
   &reftitle.returnvalues;
   <para>
diff --git a/reference/oci8/OCI-Lob/close.xml b/reference/oci8/OCI-Lob/close.xml
index 5b9124da64..ed2d4a195b 100644
--- a/reference/oci8/OCI-Lob/close.xml
+++ b/reference/oci8/OCI-Lob/close.xml
@@ -18,6 +18,11 @@
   </para>
  </refsect1>
 
+ <refsect1 role="parameters">
+  &reftitle.parameters;
+  &no.function.parameters;
+ </refsect1>
+
  <refsect1 role="returnvalues">
   &reftitle.returnvalues;
   <para>
diff --git a/reference/oci8/OCI-Lob/eof.xml b/reference/oci8/OCI-Lob/eof.xml
index 51756db669..e76ea4848b 100644
--- a/reference/oci8/OCI-Lob/eof.xml
+++ b/reference/oci8/OCI-Lob/eof.xml
@@ -17,6 +17,11 @@
   </para>
  </refsect1>
 
+ <refsect1 role="parameters">
+  &reftitle.parameters;
+  &no.function.parameters;
+ </refsect1>
+
  <refsect1 role="returnvalues">
   &reftitle.returnvalues;
   <para>
@@ -25,15 +30,6 @@
   </para>
  </refsect1>
 
- <refsect1 role="notes">
-  &reftitle.notes;
-  <note>
-   <para>
-    This function will return an Oracle error if <xref linkend="oci-lob.setbuffering"/> is enabled on the LOB.
-   </para>
-  </note>
- </refsect1>
-
  <refsect1 role="changelog">
   &reftitle.changelog;
   <informaltable>
@@ -57,6 +53,15 @@
   </informaltable>
  </refsect1>
 
+ <refsect1 role="notes">
+  &reftitle.notes;
+  <note>
+   <para>
+    This function will return an Oracle error if <xref linkend="oci-lob.setbuffering"/> is enabled on the LOB.
+   </para>
+  </note>
+ </refsect1>
+
  <refsect1 role="seealso">
   &reftitle.seealso;
   <para>
diff --git a/reference/oci8/OCI-Lob/free.xml b/reference/oci8/OCI-Lob/free.xml
index d88e56ff58..e5edaf99d1 100644
--- a/reference/oci8/OCI-Lob/free.xml
+++ b/reference/oci8/OCI-Lob/free.xml
@@ -18,6 +18,11 @@
   </para>
  </refsect1>
 
+ <refsect1 role="parameters">
+  &reftitle.parameters;
+  &no.function.parameters;
+ </refsect1>
+
  <refsect1 role="returnvalues">
   &reftitle.returnvalues;
   <para>
diff --git a/reference/oci8/OCI-Lob/getBuffering.xml b/reference/oci8/OCI-Lob/getBuffering.xml
index 9e2ea74cf4..d94f99e229 100644
--- a/reference/oci8/OCI-Lob/getBuffering.xml
+++ b/reference/oci8/OCI-Lob/getBuffering.xml
@@ -17,6 +17,11 @@
   </para>
  </refsect1>
 
+ <refsect1 role="parameters">
+  &reftitle.parameters;
+  &no.function.parameters;
+ </refsect1>
+
  <refsect1 role="returnvalues">
   &reftitle.returnvalues;
   <para>
diff --git a/reference/oci8/OCI-Lob/load.xml b/reference/oci8/OCI-Lob/load.xml
index a291d2d5ad..59e0961ab4 100644
--- a/reference/oci8/OCI-Lob/load.xml
+++ b/reference/oci8/OCI-Lob/load.xml
@@ -20,6 +20,11 @@
   </para>
  </refsect1>
 
+ <refsect1 role="parameters">
+  &reftitle.parameters;
+  &no.function.parameters;
+ </refsect1>
+
  <refsect1 role="returnvalues">
   &reftitle.returnvalues;
   <para>
diff --git a/reference/oci8/OCI-Lob/rewind.xml b/reference/oci8/OCI-Lob/rewind.xml
index ce39113c62..6b3da45589 100644
--- a/reference/oci8/OCI-Lob/rewind.xml
+++ b/reference/oci8/OCI-Lob/rewind.xml
@@ -17,6 +17,11 @@
   </para>
  </refsect1>
 
+ <refsect1 role="parameters">
+  &reftitle.parameters;
+  &no.function.parameters;
+ </refsect1>
+
  <refsect1 role="returnvalues">
   &reftitle.returnvalues;
   <para>
diff --git a/reference/oci8/OCI-Lob/size.xml b/reference/oci8/OCI-Lob/size.xml
index ed2378f28c..91b4e4f2a4 100644
--- a/reference/oci8/OCI-Lob/size.xml
+++ b/reference/oci8/OCI-Lob/size.xml
@@ -17,6 +17,11 @@
   </para>
  </refsect1>
 
+ <refsect1 role="parameters">
+  &reftitle.parameters;
+  &no.function.parameters;
+ </refsect1>
+
  <refsect1 role="returnvalues">
   &reftitle.returnvalues;
   <para>
diff --git a/reference/oci8/OCI-Lob/tell.xml b/reference/oci8/OCI-Lob/tell.xml
index c18bf73e08..1e24f69416 100644
--- a/reference/oci8/OCI-Lob/tell.xml
+++ b/reference/oci8/OCI-Lob/tell.xml
@@ -17,6 +17,11 @@
   </para>
  </refsect1>
 
+ <refsect1 role="parameters">
+  &reftitle.parameters;
+  &no.function.parameters;
+ </refsect1>
+
  <refsect1 role="returnvalues">
   &reftitle.returnvalues;
   <para>
diff --git a/reference/oci8/functions/oci-bind-by-name.xml b/reference/oci8/functions/oci-bind-by-name.xml
index 3a8cf584f5..664742de98 100644
--- a/reference/oci8/functions/oci-bind-by-name.xml
+++ b/reference/oci8/functions/oci-bind-by-name.xml
@@ -97,7 +97,7 @@
      <term><parameter>statement</parameter></term>
      <listitem>
       <para>
-       A valid OCI8 statement identifer.
+       A valid OCI8 statement identifier.
       </para>
      </listitem>
     </varlistentry>
@@ -798,13 +798,6 @@ var_dump($output2);  // false
 
  </refsect1>
 
- <refsect1 role="returnvalues">
-  &reftitle.returnvalues;
-  <para>
-   &return.success;
-  </para>
- </refsect1>
-
  <refsect1 role="notes">
   &reftitle.notes;
   <warning>
diff --git a/reference/oci8/functions/oci-set-edition.xml b/reference/oci8/functions/oci-set-edition.xml
index 768a7cb5d9..e6be7cac95 100644
--- a/reference/oci8/functions/oci-set-edition.xml
+++ b/reference/oci8/functions/oci-set-edition.xml
@@ -54,35 +54,6 @@
   </para>
  </refsect1>
 
- <refsect1 role="notes">
-  &reftitle.notes;
-  <note>
-   <title>Oracle version requirement</title>
-   <para>
-    This function is available from Oracle 11<emphasis>g</emphasis>R2 onwards.
-   </para>
-  </note>
-  <caution>
-   <title>Persistent connections</title>
-   <para>
-    To avoid inconsistencies and unexpected errors, do not use ALTER
-    SESSION SET EDITION to change the edition on persistent connections.
-   </para>
-  </caution>
-  <caution>
-   <title>DRCP Connection Pooling</title>
-   <para>
-    To avoid inconsistencies and unexpected errors when using editions
-    and <link linkend="oci8.connection">DRCP</link> with Oracle
-    11.2.0.1, keep a one-to-one correspondence between
-    the <link linkend="ini.oci8.connection-class">oci8.connection_class</link>
-    and the edition name used by applications.  Each pooled server of
-    a given connection class should only be used with one edition.
-    This restriction has been removed with Oracle 11.2.0.2.
-   </para>
-  </caution>
- </refsect1>
-
  <refsect1 role="returnvalues">
   &reftitle.returnvalues;
   <para>
@@ -138,6 +109,35 @@ echo "The result is $r\n";
   </para>
  </refsect1>
 
+ <refsect1 role="notes">
+  &reftitle.notes;
+  <note>
+   <title>Oracle version requirement</title>
+   <para>
+    This function is available from Oracle 11<emphasis>g</emphasis>R2 onwards.
+   </para>
+  </note>
+  <caution>
+   <title>Persistent connections</title>
+   <para>
+    To avoid inconsistencies and unexpected errors, do not use ALTER
+    SESSION SET EDITION to change the edition on persistent connections.
+   </para>
+  </caution>
+  <caution>
+   <title>DRCP Connection Pooling</title>
+   <para>
+    To avoid inconsistencies and unexpected errors when using editions
+    and <link linkend="oci8.connection">DRCP</link> with Oracle
+    11.2.0.1, keep a one-to-one correspondence between
+    the <link linkend="ini.oci8.connection-class">oci8.connection_class</link>
+    and the edition name used by applications.  Each pooled server of
+    a given connection class should only be used with one edition.
+    This restriction has been removed with Oracle 11.2.0.2.
+   </para>
+  </caution>
+ </refsect1>
+
 </refentry>
 
 <!-- Keep this comment at the end of the file
diff --git a/reference/oci8/functions/oci-set-module-name.xml b/reference/oci8/functions/oci-set-module-name.xml
index fd3cdc7b83..eebc552471 100644
--- a/reference/oci8/functions/oci-set-module-name.xml
+++ b/reference/oci8/functions/oci-set-module-name.xml
@@ -61,13 +61,6 @@
   </para>
  </refsect1>
 
- <refsect1 role="notes">
-  &reftitle.notes;
-  &oci.availability.note.10g;
-  &oci.clientinfo.tip;
-  &oci.roundtrip.caution;
- </refsect1>
-
  <refsect1 role="examples">
   &reftitle.examples;
   <para>
@@ -104,6 +97,13 @@ SQL> select module from v$session;
   </para>
  </refsect1>
 
+ <refsect1 role="notes">
+  &reftitle.notes;
+  &oci.availability.note.10g;
+  &oci.clientinfo.tip;
+  &oci.roundtrip.caution;
+ </refsect1>
+
  <refsect1 role="seealso">
   &reftitle.seealso;
   <para>