From 81aced57e0f78951d814fe89d5b0f930f706fb1c Mon Sep 17 00:00:00 2001 From: George Peter Banyard Date: Mon, 11 Oct 2021 00:49:59 +0100 Subject: [PATCH] Follow-up nit Use correct function name instead of the one from the copy/paste Also update pg_delete as it has the same issues --- reference/pgsql/functions/pg-delete.xml | 24 +++++++++++------------- reference/pgsql/functions/pg-insert.xml | 2 +- 2 files changed, 12 insertions(+), 14 deletions(-) diff --git a/reference/pgsql/functions/pg-delete.xml b/reference/pgsql/functions/pg-delete.xml index 0252f9e48b..7b0c6dd004 100644 --- a/reference/pgsql/functions/pg-delete.xml +++ b/reference/pgsql/functions/pg-delete.xml @@ -19,21 +19,19 @@ pg_delete deletes records from a table - specified by the keys and values - in conditions. If flags - is specified, pg_convert is applied - to conditions with the specified options. - - If options is specified, - pg_convert is applied to - assoc_array with the specified flags. + specified by the keys and values in conditions. - By default pg_delete passes raw values. Values - must be escaped or PGSQL_DML_ESCAPE option must be - specified. PGSQL_DML_ESCAPE quotes and escapes - parameters/identifiers. Therefore, table/column names became case - sensitive. + If flags is specified, + pg_convert is applied to + values with the specified flags. + + + By default pg_delete passes raw values. + Values must be escaped or the PGSQL_DML_ESCAPE flag + must be specified in flags. + PGSQL_DML_ESCAPE quotes and escapes parameters/identifiers. + Therefore, table/column names become case sensitive. Note that neither escape nor prepared query can protect LIKE query, diff --git a/reference/pgsql/functions/pg-insert.xml b/reference/pgsql/functions/pg-insert.xml index 342a7407b1..e2501ef887 100644 --- a/reference/pgsql/functions/pg-insert.xml +++ b/reference/pgsql/functions/pg-insert.xml @@ -29,7 +29,7 @@ values with the specified flags. - By default pg_update passes raw values. + By default pg_insert passes raw values. Values must be escaped or the PGSQL_DML_ESCAPE flag must be specified in flags. PGSQL_DML_ESCAPE quotes and escapes parameters/identifiers.